feat(QTDI-693): manage nested jars

[undx]

https://qlik-dev.atlassian.net/browse/QTDI-693

component-runtime:

• feat(QTDI-693): manage nested jars #969

master:

• https://github.com/Talend/tdi-studio-se/pull/10638
• https://github.com/Talend/tdi-studio-ee/pull/3346

maintenance/8.0.2 :

• https://github.com/Talend/tdi-studio-se/pull/10842
• https://github.com/Talend/tdi-studio-ee/pull/3446
• https://github.com/Talend/tcommon-studio-se/pull/7806

[ozhelezniak-talend]

left comments

[Copilot]

Pull Request Overview

This pull request implements support for managing nested JARs in the Talend SDK component runtime. The changes enable the system to detect and handle components that are packaged within fat JARs with embedded Maven repositories.

• Adds nested repository detection logic to check for MAVEN-INF/repository resources when default repository paths are used
• Extends classloader functionality to track and expose nested JAR URLs
• Updates component scanning to handle nested repositories with proper filtering

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
ContainerManager.java	Implements nested repository detection and fallback logic for fat JAR scenarios
Container.java	Adds public accessor method for nested repository status
ConfigurableClassLoader.java	Tracks nested URLs and overrides getURLs() to include them
ComponentManagerTest.java	Updates test expectations to account for nested JAR handling
ComponentManager.java	Enhances component scanning to handle nested repositories with proper filtering

Comments suppressed due to low confidence (1)

component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java:1328

• [nitpick] The log message format with manual bracket prefix is inconsistent with typical logging patterns. Consider using standard log formatting without manual prefixes.

                        log.info("[onCreate] Can't read nested scanning.properties: {}", e.getMessage());

[Copilot]

Using simple string replacement for URL handling is unreliable and may fail with encoded URLs or different URL formats. Consider using URI.create(nested.toString()).getPath() or proper URL decoding instead.

Suggested change

	rootRepo = Paths.get(nested.getFile().replace("file:", ""));
	rootRepo = Paths.get(URI.create(nested.toString()).getPath());

[Copilot]

Removed null fallback for System.getProperty("user.home") that was present in the original code. This could cause NullPointerException if the system property is not set.

Suggested change

	.orElseGet(() -> PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository"));
	// if we've defaulted to user home m2 (fallback), we want to check if we're in running in a fatjar
	if (PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository").equals(rootRepo)) {
	.orElseGet(() -> PathFactory.get(Optional.ofNullable(System.getProperty("user.home")).orElse("/tmp")).resolve(".m2/repository"));
	// if we've defaulted to user home m2 (fallback), we want to check if we're in running in a fatjar
	if (PathFactory.get(Optional.ofNullable(System.getProperty("user.home")).orElse("/tmp")).resolve(".m2/repository").equals(rootRepo)) {

[Copilot]

The field should be declared as final since it's initialized once and never reassigned. Consider making it final for better immutability.

Suggested change

	private List<URL> nestedURLs = new ArrayList<>();
	private final List<URL> nestedURLs = new ArrayList<>();

[sonar-eks]

• 66.70% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 66.70% Coverage (65.90% Estimated after merge)
• 0.00% Duplicated Code (1.40% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube