Skip to content

Show clear instructions for fixing sherif dependency version mismatches #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyleAMathews wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

Show clear instructions for fixing sherif dependency version mismatches #1040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,21 @@ jobs:
with:
main-branch-name: main
- name: Run Checks
run: pnpm run build && pnpm run test && pnpm run test:sherif
run: pnpm run build && pnpm run test
- name: Check dependency versions
run: |
if ! pnpm run test:sherif; then
echo ""
echo "=========================================="
echo "❌ Sherif found dependency version mismatches"
echo ""
echo "To fix this locally, run:"
echo " pnpm exec sherif --fix -i zod"
echo ""
echo "Then commit the changes to package.json files."
echo "=========================================="
exit 1
fi
preview:
name: Preview
runs-on: ubuntu-latest
Expand Down
Loading