Automatically subscribe/unsubscribe from TanStack Query based on collection subscriber count #462
+273
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a collection backed by a TanStack Query has no active subscribers, automatically unsubscribe from the query.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
query-db-collectioncreated a persistentQueryObserverthat remained subscribed throughout the collection's lifecycle, breaking TanStack Query'sstaleTimebehavior. From Query's perspective, there was always an "active" observer, so queries never went inactive andstaleTimenever applied.This PR fixes the issue by subscribing/unsubscribing the
QueryObserverbased on collection subscriber count. When no components are using the collection, the query becomes inactive. When the collection is observed again, TanStack Query can then refetch automatically. Soquery-db-collectionnow behaves similarly to standard TanStack Query hooks for caching and staleness.Fixes #348.