Skip to content

Angular persist query client experimental #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Apr 13, 2025
Merged

Angular persist query client experimental #8324

merged 57 commits into from
Apr 13, 2025

Conversation

OmerGronich
Copy link
Contributor

@OmerGronich OmerGronich commented Nov 22, 2024 •
edited
Loading

Angular Query Persister Plugin

  • Created angular-query-persist-client-package
  • Implemented withPersistQueryClient in new package
  • Added isRestoring provider and injection token to main angular-query package

@OmerGronich OmerGronich marked this pull request as draft November 22, 2024 14:58
@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch from 8474149 to 31c8c0e Compare November 22, 2024 15:01
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 22, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 14509a2.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 21s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-13 15:32:04 UTC

@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch 3 times, most recently from 0ff5f5c to b4d880a Compare November 23, 2024 12:00
@OmerGronich OmerGronich deleted the angular-persist-query-client-experimental branch November 23, 2024 12:00
@OmerGronich OmerGronich restored the angular-persist-query-client-experimental branch November 23, 2024 12:00
@OmerGronich OmerGronich reopened this Nov 23, 2024
@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch from 566f72a to e1ae58d Compare November 23, 2024 19:42
@OmerGronich OmerGronich marked this pull request as ready for review November 23, 2024 20:12
@arnoud-dv arnoud-dv self-assigned this Nov 26, 2024
@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch 2 times, most recently from d4fa95c to 9e4182a Compare November 29, 2024 13:27
arnoud-dv
arnoud-dv requested changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@arnoud-dv arnoud-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for now, I still need to do a more in-depth review of the persistence itself.

@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch 3 times, most recently from 3c3c8ec to ed0ed3c Compare December 7, 2024 14:40
@OmerGronich
feat(angular-query):
f327a5d 
- Created isRestoring injection token and provider
- handled restoration phase in create-base-query.ts
- handled restoration phase in
@OmerGronich
feat(angular-query): created package for experimental persistence sup…
dd92bfc 
…port, and the withPersistQueryClient feature
@OmerGronich
test(persistQuery): add tests for withPersistQueryClient
b8afd8a
@OmerGronich
docs(angular-query): add basic persister example
547ae9e
@OmerGronich
fix(angular-query): synced angular versions in new package
7130913
@OmerGronich
fix(angular-query): commit before ng update
5709184
@OmerGronich
feat(angular-query): updated example to v18
9e6ef24
@OmerGronich
fix(angular-query): fixed project name to basic-persister
962cf32
@OmerGronich
feat(angular-query): updated example basic-persister to v19
4d305a5
@OmerGronich
feat(angular-query): included back the persister package after angula…
630e462 
…r migration
crutchcorn
crutchcorn reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was requested to review this PR from OP - it generally looks good to me! Seems like a lot of edgecases handled as well.

Anything you want to me to take a closer eye on?

@arnoud-dv arnoud-dv force-pushed the angular-persist-query-client-experimental branch from 4f52f3a to 3c7a516 Compare April 13, 2025 12:46
@arnoud-dv arnoud-dv force-pushed the angular-persist-query-client-experimental branch from 3c7a516 to 12e9b00 Compare April 13, 2025 12:47
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 13, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8324

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8324

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8324

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8324

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8324

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8324

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8324

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8324

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8324

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8324

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8324

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8324

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8324

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8324

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8324

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8324

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8324

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8324

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8324

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8324

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8324

commit: 14509a2

@codecov Codecov
Copy link

codecov bot commented Apr 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.43860% with 14 lines in your changes missing coverage. Please review.

Project coverage is 44.44%. Comparing base (3471d0f) to head (14509a2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8324      +/-   ##
==========================================
+ Coverage   44.32%   44.44%   +0.12%     
==========================================
  Files         202      204       +2     
  Lines        8063     8099      +36     
  Branches     1784     1796      +12     
==========================================
+ Hits         3574     3600      +26     
- Misses       4059     4067       +8     
- Partials      430      432       +2
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.32% <62.16%> (-2.77%) ⬇️
@tanstack/eslint-plugin-query 83.02% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 95.47% <ø> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arnoud-dv arnoud-dv removed their assignment Apr 13, 2025
@arnoud-dv arnoud-dv merged commit 967c231 into TanStack:main Apr 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnoud-dv arnoud-dv arnoud-dv approved these changes

@crutchcorn crutchcorn Awaiting requested review from crutchcorn

Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmerGronich @arnoud-dv @crutchcorn