Skip to content

throw 405 response instead of 500 internal error on method mismatch #6091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliusmarminge wants to merge 4 commits into
base: main
Choose a base branch
from
+230 −1
Open

throw 405 response instead of 500 internal error on method mismatch #6091

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a317d25
throw 405 response instead of 500 internal error on method mismatch
juliusmarminge Dec 13, 2025
c335430
add tests
juliusmarminge Dec 13, 2025
95ae2c5
rm log, .only
juliusmarminge Dec 13, 2025
d60bd34
fmt
juliusmarminge Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/start-server-core/src/server-functions-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@ import { getServerFnById } from './getServerFnById'

let regex: RegExp | undefined = undefined

const methodNotAllowed = (expectedMethod: string, actualMethod: string) => {
throw new Response(`expected ${expectedMethod} method. Got ${actualMethod}`, {
status: 405,
headers: {
Allow: expectedMethod,
},
})
}

export const handleServerAction = async ({
request,
context,
Expand Down Expand Up @@ -119,7 +128,7 @@ export const handleServerAction = async ({
}

if (method.toLowerCase() !== 'post') {
throw new Error('expected POST method')
throw methodNotAllowed('POST', method)
}

let jsonPayload
Expand Down
Loading