chore: bump babel-dead-code-elimination #6187
Open
+86
−471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughBabel-related dependency version bumps and tidy-ups across multiple package.json files (most Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (8)
💤 Files with no reviewable changes (8)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:eslint,test:unit,tes... |
❌ Failed | 6m 9s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
✅ Succeeded | 1s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-12-23 02:27:13 UTC
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
packages/directive-functions-plugin/package.jsonpackages/router-plugin/package.jsonpackages/server-functions-plugin/package.jsonpackages/start-plugin-core/package.json
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Use workspace protocol
workspace:*for internal dependencies in package.json files
Files:
packages/start-plugin-core/package.jsonpackages/server-functions-plugin/package.jsonpackages/router-plugin/package.jsonpackages/directive-functions-plugin/package.json
🧠 Learnings (3)
📚 Learning: 2025-12-06T15:03:07.223Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T15:03:07.223Z
Learning: Applies to **/package.json : Use workspace protocol `workspace:*` for internal dependencies in package.json files
Applied to files:
packages/start-plugin-core/package.jsonpackages/router-plugin/package.json
📚 Learning: 2025-11-02T16:16:24.898Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5732
File: packages/start-client-core/src/client/hydrateStart.ts:6-9
Timestamp: 2025-11-02T16:16:24.898Z
Learning: In packages/start-client-core/src/client/hydrateStart.ts, the `import/no-duplicates` ESLint disable is necessary for imports from `#tanstack-router-entry` and `#tanstack-start-entry` because both aliases resolve to the same placeholder file (`fake-start-entry.js`) in package.json during static analysis, even though they resolve to different files at runtime.
Applied to files:
packages/start-plugin-core/package.jsonpackages/router-plugin/package.jsonpackages/directive-functions-plugin/package.json
📚 Learning: 2025-10-01T18:31:35.420Z
Learnt from: schiller-manuel
Repo: TanStack/router PR: 5330
File: e2e/react-start/custom-basepath/src/routeTree.gen.ts:58-61
Timestamp: 2025-10-01T18:31:35.420Z
Learning: Do not review files named `routeTree.gen.ts` in TanStack Router repositories, as these are autogenerated files that should not be manually modified.
Applied to files:
packages/router-plugin/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (3)
packages/server-functions-plugin/package.json (1)
71-71: LGTM!The dependency version bump is consistent with the other packages in this PR.
packages/start-plugin-core/package.json (1)
75-75: LGTM!The dependency version bump aligns with the other packages in this PR.
packages/router-plugin/package.json (1)
117-117: LGTM!The dependency version bump is consistent with the other packages in this PR.
| "@babel/types": "^7.27.7", | ||
| "@tanstack/router-utils": "workspace:*", | ||
| "babel-dead-code-elimination": "^1.0.10", | ||
| "babel-dead-code-elimination": "^1.0.11", |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat packages/directive-functions-plugin/package.json | head -80 | tail -20Repository: TanStack/router
Length of output: 567
Fix version specification: babel-dead-code-elimination does not have a 1.0.11 release.
The latest available version of babel-dead-code-elimination is 1.0.10, not 1.0.11. Change the dependency to "babel-dead-code-elimination": "^1.0.10" to resolve the version correctly. The package is maintained with MIT license and has 26 dependents, so no security concerns exist once the version is corrected.
🤖 Prompt for AI Agents
In packages/directive-functions-plugin/package.json around line 73 the
dependency version for babel-dead-code-elimination is incorrect (1.0.11 does not
exist); update the version specifier to the latest published release by
replacing "babel-dead-code-elimination": "^1.0.11" with
"babel-dead-code-elimination": "^1.0.10" and run npm install (or yarn) to update
lockfiles accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.