Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/react/start-clerk-basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@clerk/tanstack-react-start": "^0.26.3",
"@clerk/tanstack-react-start": "^0.27.14",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Check if this is a monorepo setup
git ls-files package.json | head -20

Repository: TanStack/router

Length of output: 71


🏁 Script executed:

# Check root directory structure
ls -la | grep -E "package.json|lerna|workspaces"

Repository: TanStack/router

Length of output: 124


🏁 Script executed:

# Look for @clerk/tanstack-react-start package definition
fd -t f "package.json" | xargs grep -l '"name".*tanstack-react-start' 2>/dev/null

Repository: TanStack/router

Length of output: 1007


🏁 Script executed:

# Examine the current file content and git diff if available
cat -n examples/react/start-clerk-basic/package.json

Repository: TanStack/router

Length of output: 1246


🏁 Script executed:

cat -n package.json | head -50

Repository: TanStack/router

Length of output: 2574


🏁 Script executed:

# Search for @clerk/tanstack-react-start package definition
find . -type f -name "package.json" -exec grep -l '"name".*"@clerk/tanstack-react-start"' {} \;

Repository: TanStack/router

Length of output: 41


🏁 Script executed:

# Check workspace configuration in root package.json
cat package.json | grep -A 20 "workspaces"

Repository: TanStack/router

Length of output: 41


🏁 Script executed:

# Check if @tanstack packages are internal to the monorepo
find . -type d -name "@tanstack" | head -5

Repository: TanStack/router

Length of output: 41


🏁 Script executed:

# Search for packages directory to understand monorepo structure
ls -la packages/ 2>/dev/null | head -20

Repository: TanStack/router

Length of output: 1289


🏁 Script executed:

# Check if other example files use workspace: protocol
find . -path "*/examples/*/package.json" -o -path "*/e2e/*/package.json" | xargs grep -h "workspace:\*" 2>/dev/null | head -10

Repository: TanStack/router

Length of output: 614


🏁 Script executed:

# Check what protocol @tanstack packages use in other files
find . -path "*/examples/*/package.json" -o -path "*/e2e/*/package.json" | xargs grep "@tanstack" 2>/dev/null | head -20

Repository: TanStack/router

Length of output: 2086


🏁 Script executed:

# Look at the pnpm-workspace.yaml or similar configuration
cat pnpm-workspace.yaml 2>/dev/null || cat .npmrc 2>/dev/null || echo "No workspace config found"

Repository: TanStack/router

Length of output: 577


🏁 Script executed:

# Check if @clerk/tanstack-react-start is a package in the monorepo
find . -type f -name "package.json" -path "*/packages/*" -exec grep -l '@clerk/tanstack-react-start' {} \;

Repository: TanStack/router

Length of output: 41


🏁 Script executed:

# Check the specific e2e/react-start/clerk-basic/package.json more carefully
# and compare with other react-start e2e examples
cat e2e/react-start/basic/package.json | grep -A 10 dependencies

Repository: TanStack/router

Length of output: 421


🏁 Script executed:

# Check if this file path actually exists or if it's in a different location
find . -name "package.json" | grep -i "clerk" | grep -i basic

Repository: TanStack/router

Length of output: 149


🏁 Script executed:

# Now let's examine the actual file at the correct location
cat -n e2e/react-start/clerk-basic/package.json

Repository: TanStack/router

Length of output: 1388


🏁 Script executed:

# Check if there were recent changes to this file
git log --oneline e2e/react-start/clerk-basic/package.json 2>/dev/null | head -5

Repository: TanStack/router

Length of output: 94


🏁 Script executed:

# Compare with the examples version if it exists
if [ -f "examples/react/start-clerk-basic/package.json" ]; then
  echo "=== examples version ==="; 
  cat examples/react/start-clerk-basic/package.json | grep -A 12 dependencies;
else
  echo "examples/react/start-clerk-basic/package.json does not exist";
fi

Repository: TanStack/router

Length of output: 482


🏁 Script executed:

# Check npm registry for the package and its versions
npm view @clerk/[email protected] version 2>/dev/null || echo "Version not found"

Repository: TanStack/router

Length of output: 66


🏁 Script executed:

# Check latest stable version
npm view @clerk/tanstack-react-start version 2>/dev/null || echo "Package query failed"

Repository: TanStack/router

Length of output: 66


🏁 Script executed:

# Check available versions around 0.27.14
npm view @clerk/tanstack-react-start versions --json 2>/dev/null | tail -30

Repository: TanStack/router

Length of output: 1135


Address the version mismatch between e2e and examples directories.

Version 0.27.14 is stable and currently the latest. However, there's a significant inconsistency: e2e/react-start/clerk-basic/package.json uses ^0.19.0 while this file uses ^0.27.14. This 0.8 minor version gap could lead to different behavior between the test environment and the example, potentially hiding compatibility issues. Either both should be updated to 0.27.14, or a clear rationale should document why they need different versions.

🤖 Prompt for AI Agents
In @examples/react/start-clerk-basic/package.json at line 13, The dependency
version for "@clerk/tanstack-react-start" is inconsistent between the example
and e2e test; update the version in the out-of-sync package.json to ^0.27.14 so
both use the same stable release, or if there is a deliberate reason for keeping
^0.19.0 in e2e, add a short comment in the e2e package.json (or a README)
explaining the rationale and compatibility constraints; ensure you change the
version string for "@clerk/tanstack-react-start" in the mismatched package.json
(or add the explanatory note) so behavior is consistent or clearly documented.

"@tanstack/react-router": "^1.146.2",
"@tanstack/react-router-devtools": "^1.146.2",
"@tanstack/react-start": "^1.146.3",
Expand Down
6 changes: 6 additions & 0 deletions examples/react/start-clerk-basic/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,10 @@ export default defineConfig({
tanstackStart(),
viteReact(),
],
// See https://github.com/TanStack/router/issues/5738
resolve: {
alias: [
{ find: 'use-sync-external-store/shim/index.js', replacement: 'react' },
],
},
})
117 changes: 90 additions & 27 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading