Skip to content

Use ptrdiff_t in repeat_n_view to satisfy weakly_incrementable #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scuzqy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use ptrdiff_t in repeat_n_view to satisfy weakly_incrementable #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/tl/repeat_n.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace tl {
: public std::ranges::view_interface<repeat_n_view<T>> {
private:
tl::semiregular_box<T> value_;
std::size_t n_;
std::ptrdiff_t n_;

class cursor {
T const* value_;
Expand All @@ -25,7 +25,7 @@ namespace tl {
static constexpr bool single_pass = false;

cursor() = default;
constexpr explicit cursor(T const* value, std::size_t pos)
constexpr explicit cursor(T const* value, std::ptrdiff_t pos)
: value_{ value }, pos_( pos ){}

constexpr decltype(auto) read() const {
Expand Down Expand Up @@ -62,7 +62,7 @@ namespace tl {

public:
repeat_n_view() = default;
repeat_n_view(T t, std::size_t n) : value_(std::move(t)), n_(n) {}
repeat_n_view(T t, std::ptrdiff_t n) : value_(std::move(t)), n_(n) {}

constexpr auto begin() const {
return basic_iterator{ cursor(std::addressof(value_.value()), n_) };
Expand All @@ -74,15 +74,15 @@ namespace tl {
};

template <class T>
repeat_n_view(T&&, std::size_t)->repeat_n_view<T>;
repeat_n_view(T&&, std::ptrdiff_t)->repeat_n_view<T>;

namespace views {
namespace detail {
class repeat_n_fn {
public:
template <class T>
requires std::copyable<std::remove_cvref_t<T>>
constexpr auto operator()(T&& v, std::size_t n) const {
constexpr auto operator()(T&& v, std::ptrdiff_t n) const {
return tl::repeat_n_view{ std::forward<T>(v), n };
}
};
Expand Down