Bumped Discord.js to v14.11.0 + discord plugins + log-parser#297
Closed
magicoflolis wants to merge 2 commits intoTeam-Silver-Sphere:masterfrom
Closed
Bumped Discord.js to v14.11.0 + discord plugins + log-parser#297magicoflolis wants to merge 2 commits intoTeam-Silver-Sphere:masterfrom
magicoflolis wants to merge 2 commits intoTeam-Silver-Sphere:masterfrom
Conversation
Signed-off-by: Magic <magicoflolis@tuta.io>
Signed-off-by: Magic <magicoflolis@tuta.io>
Collaborator
|
@magicoflolis Has this been tested on an live server? |
Collaborator
|
Also more likely for versioning we may ask you to make separate PRs for each major change. That is something I’ll have to read into the bot with. |
Contributor
This is a good suggestion by werewolfboy. I would like to test it, but I am hesitant to test these all at once. A separate PR for each major change might make it easier to track and understand with better details. |
Author
|
Merged changed to a new branch & created a new pull request #300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Been working with SquadJS for 3 months, it's great, but could be greater!
Additions & Changes
core/log-parser/index.jsAverage matching latencybeing NaN in the log.squad-server/package.jsonsquad-server/factory.jssquad-server/plugins/*cbl-info.js, added exception for when there is no SteamID within the data ("possible log parser issue or data is not always available during trigger event").discord-base-plugin.js, reworked sendDiscordMessage function, added additional utility functionssquad-server/plugins/discord-*.jsWhile writing this I might have missed a few issues
cbl-info.jsmay only display the default footer and notPowered by SquadJS and the Community Ban List