Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceHelper improvements #10741

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Profpatsch
Copy link
Contributor

Fixes a possible NullPointerException & improves function names

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Due diligence

There wase one place where `null` was not checked. We use the fallback
function there.

For the `name` function we make clear that `"<unknown>"` is returned
iff the service is not known.
Instead of going through the Service ID, we provide some more specific
wrappers to discourage passing service IDs around.
@Profpatsch Profpatsch changed the title Improve service id fetching ServiceHelper improvements Jan 23, 2024
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants