Skip to content

Conversation

@HatakeKakashri
Copy link
Contributor

@HatakeKakashri HatakeKakashri commented Oct 24, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Background:

  • While testing the Android Auto app, users missed having a quick way to shuffle and play the playlist.
  • This adds support to shuffle and play the playlist directly from the Android Auto app.

Changes:

  • Added a "Shuffle and play" button as the first item in the playlist view.
  • The button is only displayed for non-empty playlists to prevent confusion.

Before/After Screenshots/Screen Record

Screencast_20251028_231752.webm

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label Oct 24, 2025
Background:
- While testing the Android Auto app, I missed having a quick way to shuffle and play the playlist.
- This adds support to shuffle and play the playlist directly from the Android Auto app.

Changes:
- Added a "Shuffle and play" button as the first item in the playlist view.
- The button is only displayed for non-empty playlists to prevent confusion.

PlayQueue refactor:
- Refactored the `PlayQueue.shuffle()` method to support different shuffling modes
- Add optional `shuffleAll` parameter to `PlayQueue.shuffle()` method with default value false
- When shuffleAll=false (default): preserves currently playing item at the head of the queue (existing behavior)
- When shuffleAll=true: shuffles all items without preserving the current item position
- Update documentation to clearly explain both modes of operation
@HatakeKakashri HatakeKakashri force-pushed the android_auto/support_shuffle_play branch from 3fa81fa to 6794325 Compare October 28, 2025 17:55
@HatakeKakashri
Copy link
Contributor Author

Most of the work on this is done, there is just one more bug remaining where "For You" section shows the Shuffle button. I would like to remove that before merging the changes.
Screenshot_20251028_232044

CC: @Stypox, @TobiGr

@TobiGr TobiGr added feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) Android Auto Issue is related to Android Auto labels Oct 28, 2025
@TobiGr
Copy link
Contributor

TobiGr commented Oct 28, 2025

I don't use NewPipe with Android Auto. I don't know the typical use cases and flows. That's why I am not in a good position to make a decision here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Auto Issue is related to Android Auto feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants