on.soundcloud fixes #1388
Merged
on.soundcloud fixes #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TobiGr
added
bug
Contributor
Author
|
I'm unsure how to run this with RecordingDownloader like the failing tests say -- they successfully run on my machine |
Contributor
|
The tests are failing because you changed tests which require requests to external servers. To minimize the load on external servers and to make tests more reliable we are using so called "mocks" to simulate the requests. This is done by "recording" network requests and using those records when running the tests. See https://teamnewpipe.github.io/documentation/05_Mock_tests/ for more info. |
TobiGr
approved these changes
Oct 14, 2025
Contributor
|
thank you! |
AudricV
reviewed
Oct 14, 2025
TobiGr
added a commit
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TeamNewPipe/NewPipe#12694
also related: 02e14b8
The name change commit isn't necessary but I would appreciate it for git history view consistency