Upgrade to v5 #31
Upgrade to v5 #31
Conversation
Before this patch, when `enableOptimizedPartialRendering` is enabled we would record the bounding boxes of the various operations on the first render. This patches change it to happen on the first render that we know will also need a detail view, so that the performance cost is not paid for the case when the detail view is not used.
Fix JSDoc description in src/display/api.js
It helps to reduce the number of iterations so it makes the algorithm slightly faster in general.
Only record bboxes when needed
Use a dichotomy to find a color with a good contrast ratio
This allows Jasmine to track skipped tests and makes it easier to discover them using e.g. `grep`.
… a Differences array in the encoding dict as non-symbolic It fixes #20232.
Replace manual returns with `pending` in the integration tests
This is a major version bump, but the changelog at https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v61.0.0 doesn't indicate any breaking changes that should impact us.
Consider a ttf font with both Symbolic and Nonsymbolic flags set with a Differences array in the encoding dict as non-symbolic
And: - improve the editing dialog in removing menu; - position correctly the popup on the left/right depending on the direction value.
Update dependencies and translations to the most recent versions
[Editor] Add a new popup for comments (bug 1987425)
[Annotation] Use the new popup in reading mode (bug 1987426)
Only fix the popup position if the user didn't change it. And don't adjust the dialog position since it should have the same as the popup.
[Editor] Fix the position of the comment popup and its dialog
[Annotation] Save the comment changes made in reading mode (bug 1987427)
Change info to use console.info and warn function to use console.warn, this not only makes sense semantically but also in practice server side runtimes like deno write console.log to stdout, and console.warn to stderr (info goes to stdout, unfortunately?) this is important because logging to stdout can break some cli apps.
Avoid unused css variables
Use `console.warn`/`console.info` where appropriate
And add an aria label to the dialog.
[Editor] Fix the focus outline for the comment dialog buttons
Add setter for some FontFaceObject properties
… around the group It fixes #20225. And only add the extra spaces where it's required depending on their position in the query string.
…-deletion fix: deleteAnnotationElement takes a full editor object
When searching for a group of punctuation signs, only add extraspaces around the group
[XFA] Set default max value in occur tag to -1 (bug 1998843)
This dependency got introduced during the move to Fluent for localization (bug 1858715), but it wasn't added to `package.json` at the time. This worked because other dependencies already installed it, but we shouldn't rely on that, so this commit explicitly includes it in `package.json` instead. Fixes 66982a2.
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ons/checkout-6 Bump actions/checkout from 5 to 6
Include missing `cached-iterable` dev dependency in `package.json`
Don't use firstChild/lastChild when getting elements (follow-up of #20447)
[Editor] Allow to save an edited comment in using CTRL+Enter shortcut.
…en searching ICU has been updated in Firefox (see https://bugzilla.mozilla.org/show_bug.cgi?id=2000225). The char `0xA7F1` is now alphabetic and can be normalized as a "S".
For now its use is limited to the comment sidebar but it'll be used for the new one containing the thumbnails. And make the sidebar more accessible with the keyboard or a screen reader.
Create a sidebar object
Fix the regex string used to find the chars to normalize with NFKC when searching
This commit updates the release pipeline to use OIDC trusted publishing now that we have configured it between GitHub Actions and NPM. This solution allows us to remove the token variable (because there is no longer a fixed token) and provenance flag (because provenance attestations are generated by default with this approach); refer to https://docs.npmjs.com/trusted-publishers for more information.
Use OIDC trusted publishing in the GitHub Actions release workflow
In using a blob instead of a base64 string it's possible to reduce the memory. And simplify a bit the thumbnails themselves.
Slightly reduce the memory used by thumbnails
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function used() { | ||
| usedByUsed(); | ||
| return; | ||
| usedByRemovedCode(); |
Check warning
Code scanning / CodeQL
Unreachable statement Warning library
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix this issue, the unreachable function call usedByRemovedCode(); on line 8 should be removed, as it will never be executed. Removing this line eliminates dead code and potential confusion, while keeping the codebase clean and maintainable. No further changes are required; the functionality of the used function remains unchanged, and the functions themselves can remain for now unless further unused function analysis suggests more removals across the codebase.
| @@ -5,7 +5,6 @@ | ||
| function used() { | ||
| usedByUsed(); | ||
| return; | ||
| usedByRemovedCode(); | ||
| } | ||
| function unused() { | ||
| usedByUnused(); |
| return; | ||
| usedByRemovedCode(); | ||
| } | ||
| function unused() { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note library
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
The best way to fix the problem is to remove the unused function declaration entirely. This means deleting lines 10 through 12 in external/builder/fixtures_babel/unused-function.js, which contain the full declaration and body of the unused function. No additional imports or changes are required, as removing this code has no effect on the existing functionality.
| @@ -7,8 +7,6 @@ | ||
| return; | ||
| usedByRemovedCode(); | ||
| } | ||
| function unused() { | ||
| usedByUnused(); | ||
| } | ||
|
|
||
|
|
||
| used(); |
| @@ -0,0 +1,20 @@ | |||
| class A { | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note library
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix the problem of the unused class A, simply remove its entire definition from the file. This means deleting lines 1 through 20, which comprise the class. Since there is nothing else in the file and no evidence of usage, this is the minimal and most direct change that resolves the CodeQL warning without affecting any other logic (since, based on the provided snippet, there is no logic that depends on A). No additional methods, imports, or variable definitions are needed.
| @@ -1,20 +1 @@ | ||
| class A { | ||
| static {} | ||
| static { | ||
| { foo() } | ||
| } | ||
| static { | ||
| {;} | ||
| } | ||
| static { | ||
| if (PDFJSDev.test('TRUE')) { | ||
| var a = 0; | ||
| } | ||
| } | ||
|
|
||
| static { | ||
| if (PDFJSDev.test('FALSE')) { | ||
| var a = 1; | ||
| } | ||
| } | ||
| } |
| @@ -0,0 +1,8 @@ | |||
| class A { | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note library
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To resolve the unused class A warning, simply remove the entire class definition from the file. This involves deleting everything from the start of the class A { declaration through the closing brace. All contained static blocks will be removed as part of this. No additional imports, definitions, or code is necessary, and this change will have no effect on the code's runtime behaviour, since A was not referenced anywhere.
| @@ -1,8 +1 @@ | ||
| class A { | ||
| static { | ||
| foo(); | ||
| } | ||
| static { | ||
| var a = 0; | ||
| } | ||
| } |
| chrome.tabs.onRemoved.addListener(function (tabId) { | ||
| delete g_referrers[tabId]; | ||
| }); | ||
| function canRequestBody(tabId, frameId) { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Copilot Autofix
AI about 1 month ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
himynameisjonas
left a comment
himynameisjonas
left a comment
There was a problem hiding this comment.
Looks like the build script doesn't build a web version anymore. Previous versions had a web folder in the build output that we use in the iframe on app.teamtailor.com.
15 participants
Upgrade to version 5️⃣ 🪩 🕺
These files had custom implementations which should be intact: Teamtailor allowlist and CDN/S3 exceptions in [web/app.js](https://github.com//pull/31/changes#diff-e24e4bd32090b0c400a70f02d1b844df95c9bbe62cd0b280f4397e9f4194fe44). Cross‑origin embed event suppression in [web/viewer.js](https://github.com//pull/31/changes#diff-987d91686287a25ac2405baaf17b699a5fc1a176a53f8ea347a72ef486001f7b). “Open urls in new tab” mutation observer in [web/viewer.html](https://github.com//pull/31/changes#diff-987d91686287a25ac2405baaf17b699a5fc1a176a53f8ea347a72ef486001f7b). Teamtailor notes in [README.md](https://github.com//pull/31/changes#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5).
I looked at the custom implementations these commits from Pull Requests since the last upgrade; and all of their changes are still present:
d7ece50 (multi-dash bucket support + linting): web/app.js (line 2423) and web/app.js (line 2425).
32a3527 (escaped periods in host regex): web/app.js (line 2425) and web/app.js (line 2426).
33c93b5 (teamtailor-cdn allowlist): web/app.js (line 2426) and web/app.js (line 2445).
01a0d0e (tt-dev buckets allowed): web/app.js (line 2425).
650d100 (disable parent document dispatch to avoid cross-domain error): web/viewer.js (line 315) and web/viewer.js (line 317).
66741cf (deploy instructions in README): README.md (line 1) and README.md (line 4).