Fix the filter for broken tests in maximum test detection #10547
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation didn't correctly filter broken tests. Ouput before: ``` Framework cutelyst defines 14 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework ffead-cpp defines 14 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework go defines 11 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework falcon defines 11 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework officefloor defines 11 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework act defines 11 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework micronaut defines 12 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework pippo defines 12 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework php defines 11 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework ubiquity defines 12 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. ``` Output after: ``` Framework cutelyst defines 14 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework falcon defines 11 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework micronaut defines 12 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework pippo defines 12 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. Framework php defines 11 tests in benchmark_config.json (max is 10). Contact maintainers and remove deprecated or discarded ones to make room. ```
msmith-techempower
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation didn't correctly filter broken tests.
For example "go" has some tests tagged as broken, but all tests are counted.
Ouput before:
Output after: