Skip to content

Assignment - movie app #54

Open
qabalany wants to merge 8 commits intoTechnigo:mainfrom
qabalany:main
Open

Assignment - movie app #54
qabalany wants to merge 8 commits intoTechnigo:mainfrom
qabalany:main

Conversation

@qabalany
Copy link
Copy Markdown

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you have collected the key and all the API URLs along with the methods in one place so it's easy to change and reuse.

Remember that generating hand-ins is not permitted according to the student handbook. I can see that you even have a generation guide for the AI in there. Only use AI for learning purposes, that way you will learn a lot more and quicker! And once you have come to a good level of understanding and working with code, then you can start to leverage AI for a more rapid development cycle.

There is a lot of inline styling, make use of either normal CSS or something like styled components or Tailwind. Inline styling breaks the cascading effect of CSS and doesn't work well at scale.
Also try to collect reused colors and breakpoints in a theme file or similar.

Think of abstracting elements into components that can be reused, like the or paragraphs/headings for example.

Otherwise good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants