change: modernize the code slightly by using import/export #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the other PRs are settled, I'll come make sure this is updated and still works. Anyone feel free to ping me if I get distracted. 😅 |
@saibotsivad just a friendly reminder about this PR 😄 |
|
oh hey yeah, as long as the merge conflicts are dealt with, this seems like a fine change to make? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Making this PR now so I don't lose track of it while waiting for other PRs to settle.)
This one needs to wait for #141
I didn't modernize anything else in particular, I just changed all the
requires toimports andmodule.exporttoexport default.