Browser tests in CI? #146
Open
Browser tests in CI? #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saibotsivad
reviewed
Jul 13, 2021
| steps: | ||
| - checkout | ||
| - run: sudo apt-get install xvfb | ||
| - run: npm ci |
There was a problem hiding this comment.
I think you need to run npm run build here first? I notice in the one I made that it runs npm run test which has build as a side effect.
There was a problem hiding this comment.
The browser script runs it too... https://github.com/TehShrike/abstract-state-router/blob/master/package.json#L9 ...I'm not sure what's going wrong :-x
There was a problem hiding this comment.
You've got the browser scripts in a different job. My understanding is that assets weren't available across jobs unless you specified it or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.