Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d.ts type definition error #179

Open
eczn opened this issue Nov 18, 2019 · 7 comments · May be fixed by #211
Open

d.ts type definition error #179

eczn opened this issue Nov 18, 2019 · 7 comments · May be fixed by #211

Comments

@eczn
Copy link

eczn commented Nov 18, 2019

image

⬆️ the type of t4.a should be a number type, not never.
@TehShrike
Copy link
Owner

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

@eczn
Copy link
Author

eczn commented Nov 19, 2019

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

#181 here

@eczn
Copy link
Author

eczn commented Nov 19, 2019

image

@hakimio
Copy link

hakimio commented Feb 3, 2020

@TehShrike any plans to merge the PR?

@bryan-hunter bryan-hunter mentioned this issue May 29, 2020
Open
@TehShrike
Copy link
Owner

TehShrike commented Oct 17, 2020 •
edited
Loading

Sorry for not looking in for a while – any other TS folks want to give #198 a review? @teppeis @RebeccaStevens @s-edlund

@RebeccaStevens
Copy link

I can probably give it a review a bit later today

@RebeccaStevens
Copy link

Sorry I took a bit longer to do this than I said I would but I just reviewed it. It's good but I found some issue with it; I've commented them there.

@RebeccaStevens RebeccaStevens linked a pull request Nov 5, 2020 that will close this issue
Open
@RebeccaStevens RebeccaStevens mentioned this issue Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TypeScript Types RebeccaStevens/fork-deepmerge
4 participants
@hakimio @TehShrike @RebeccaStevens @eczn