Add TypeScript Types #211
Open
Add TypeScript Types #211
+2,067
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting the types right on this library is way harder than I though it would be. 😫 |
RebeccaStevens
force-pushed
the
typed-deepmerge
branch
6 times, most recently
from
d409acd
to
67a71ed
Compare
RebeccaStevens
force-pushed
the
typed-deepmerge
branch
5 times, most recently
from
8a78898
to
ba60c9b
Compare
|
This has really turned into a much bigger job than I initially thought it would be (or maybe I'm just doing a bit of overkill 😛). Anyway, @TehShrike I think I've got the types right now. (idk what Travis is doing, it hasn't successfully booted a vm all day). Would you be able to review? Or get someone else to? I might add some more test and maybe refactor things a little more so they are easier to follow - even I am getting a little confused with all the mapped types going on. Also, small note: Some of the parts of the typings rely on some new features in TypeScript 4.1 which isn't out yet (I'm using the RC). I believe TS 4.1 will be released sometime next week. |
RebeccaStevens
force-pushed
the
typed-deepmerge
branch
from
ba60c9b
to
6e52e65
Compare
RebeccaStevens
force-pushed
the
typed-deepmerge
branch
3 times, most recently
from
ac5cb5c
to
acbe9b7
Compare
RebeccaStevens
force-pushed
the
typed-deepmerge
branch
from
acbe9b7
to
bab1c5f
Compare
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 12, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 12, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 12, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 12, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 13, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 16, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 16, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 16, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 17, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 17, 2020
Closed
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 17, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 18, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 19, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 27, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 27, 2020
|
Why didn't we ever merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work @bryan-hunter did in #198.
Fixes #147, fixes #179.
Closes: #148, closes #181, closes #198.