#185 change customMerge signature for merging empty values #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or empty string overwrites
osmestad
approved these changes
Oct 6, 2020
enjikaka
approved these changes
Oct 6, 2020
|
@TehShrike anything i should do differently maybe? |
|
@TheHaff me and @TehShrike are working on v5 of this library atm - this will probably be merged into the v5 branch. Do you want to rebase this PR off that branch? |
ah ok sweet, my rebase got messy so i just created a new one over here #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change customMerge signature to allow for ignoring null or empty string overwrites.
ref: #185 (comment)
i think it would be nice to just have a ignoreEmpty optional flag but i threw in a util function there so this ain't so bad is it?