Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-deprecate clone, make it not a liar about the root object #225

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

TehShrike
Copy link
Owner

Fixes #208
Potentially fixes #186
Fixes #163
Potentially fixes #212

Fixes #208
Potentially fixes #186
Fixes #163
Potentially fixes #212
@TehShrike
Copy link
Owner Author

Going back to #209 I was having trouble parsing it all – is there anything missing from the implementation in this pull request here?

@TehShrike TehShrike added this to the 5.0.0 milestone Jan 20, 2021
@RebeccaStevens
Copy link

I think this is all good to be merged.

I don't think it fully addresses #186 or #212 though, I'll work on them after this (and my typescript work) is merged.

@TehShrike
Copy link
Owner Author

Yeah, #186 and #212 both also described other new behaviors, but I'm not sure that any of those other new behaviors are actually a good idea to implement, and I'd want to talk a lot more before moving forward with any of them.

But I am solidly on board with undeprecating clone and making it apply to the target root.

@TehShrike TehShrike merged commit d51d92d into v5 Jan 21, 2021
@TehShrike TehShrike deleted the 208-dont-always-clone-over-destination branch January 21, 2021 14:49
@lipnitsk
Copy link

@TehShrike are you planning on releasing v5 anytime soon?

@RebeccaStevens
Copy link

@lipnitsk There's no current timeline for v5's release. In the mean time I recommend using deepmerge-ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants