Skip to content

Conversation

@futz12
Copy link
Contributor

@futz12 futz12 commented Jan 1, 2026

No description provided.

@github-actions github-actions bot added the vulkan label Jan 1, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.79%. Comparing base (06c4da1) to head (8bcb4db).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6474       +/-   ##
===========================================
- Coverage   95.90%   94.79%    -1.12%     
===========================================
  Files         845      548      -297     
  Lines      265399   160114   -105285     
===========================================
- Hits       254531   151779   -102752     
+ Misses      10868     8335     -2533     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Vulkan shader support for the GridSample layer, enabling GPU-accelerated grid sampling operations with bilinear, nearest, and bicubic interpolation modes.

Key Changes

  • Implements a complete Vulkan compute shader for grid sampling with support for 2D and 3D input tensors
  • Adds GridSample_vulkan class with pipeline creation, destruction, and forward pass implementation
  • Supports multiple interpolation modes (bilinear, nearest, bicubic) and padding modes (zeros, border, reflection)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/layer/vulkan/shader/gridsample.comp Complete compute shader implementing grid sampling with coordinate transformations, boundary handling, and interpolation algorithms
src/layer/vulkan/gridsample_vulkan.h Header file declaring the GridSample_vulkan class inheriting from GridSample base class
src/layer/vulkan/gridsample_vulkan.cpp Implementation of Vulkan-specific pipeline management and forward pass with dynamic dimension handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ futz12
❌ nihui
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Please enable github action in YOUR FORKED REPO to make code-format workflow work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants