feat(drawer): 传入 confirmBtnProps 和 cancelButtonProps 可分别自定义按钮
#2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyarn
reviewed
Aug 2, 2023
| @@ -9,12 +9,14 @@ className | String | - | 类名 | N | |||
| style | Object | - | 样式，TS 类型：`React.CSSProperties` | N | |||
| attach | String / Function | - | 抽屉挂载的节点，默认挂在组件本身的位置。数据类型为 String 时，会被当作选择器处理，进行节点查询。示例：'body' 或 () => document.body。TS 类型：`AttachNode`。[通用类型定义](https://github.com/Tencent/tdesign-react/blob/develop/src/common.ts) | N | |||
| body | TNode | - | 抽屉内容。TS 类型：`string \| TNode`。[通用类型定义](https://github.com/Tencent/tdesign-react/blob/develop/src/common.ts) | N | |||
| cancelBtn | TNode | - | 取消按钮，可自定义。值为 null 则不显示取消按钮。值类型为字符串，则表示自定义按钮文本，值类型为 Object 则表示透传 Button 组件属性。使用 TNode 自定义按钮时，需自行控制取消事件。TS 类型：`FooterButton` | N | |||
| cancelBtn | TNode | - | 取消按钮，可自定义。值为 null 则不显示取消按钮。值类型为字符串，则表示自定义按钮文本。使用 TNode 自定义按钮时，需自行控制取消事件。TS 类型：`FooterButton` | N | |||
| cancelBtnProps | ButtonProps | - | [Button API Documents](./button?tab=api)。[通用类型定义](https://github.com/Tencent/tdesign-react/blob/develop/src/common.ts)。[详细类型定义](https://github.com/Tencent/tdesign-react/blob/develop/src/drawer/type.ts) | N | |||
There was a problem hiding this comment.
issue的意思是cancelBtn没有支持Object类型 不需要增加API
There was a problem hiding this comment.
我是这样认为的， cancelBtn如果支持Object类型的话， 会使代码冗余，增加判断条件， 而且参数也不语义化， 所以cancelButton 的props 应该和 cancelButton TNode分开
There was a problem hiding this comment.
这里主要有两个问题 一个是这个要录到API平台来统一管理 一个是目前1.0版本的设计是这样子 涉及类似设计的组件比较多 不能单独为这一个组件改动API 这样和其他组件也不是很一致了 所以会比较希望这种大优化放在2.0版本然后一起调整一下 同步在这里下
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
传入
confirmBtnProps和cancelButtonProps可分别自定义按钮🤔 这个 PR 的性质是？
🔗 相关 Issue
#2407
💡 需求背景和解决方案
📝 更新日志
feat(Drawer): 传入
confirmBtnProps和cancelButtonProps可分别自定义确定按钮和取消按钮的 props。本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单