feat(table): add class to identify expanded and folded row #3099
+44
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyarn
requested review from
honkinglin,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
|
|
HaixingOoO
approved these changes
Sep 12, 2024
uyarn
force-pushed
the
feat/table-expand-class
branch
from
087b368
to
bd469b9
Compare
uyarn
force-pushed
the
feat/table-expand-class
branch
from
0e35ea8
to
a0279f9
Compare
HaixingOoO
reviewed
Sep 19, 2024
Comment on lines
83
to
86
| const tRowClassNames = (() => { | ||
| const tClassNames = [props.rowClassName, selectedRowClassNames]; | ||
| const tClassNames = [props.rowClassName, selectedRowClassNames, getExpandedRowClass]; | ||
| return tClassNames.filter((v) => v); | ||
| })(); |
There was a problem hiding this comment.
@chaishi 一块改掉呢？还是这里有什么每次都要执行的需求？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat(Table): 可展开收起场景下新增
t-table__row--expanded和t-table__row--folded用于区分展开和收起的行本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单