Add variables to group and layer models #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
submarcos
reviewed
Jan 3, 2024
project/terra_layer/models.py
Outdated
| @@ -164,6 +167,8 @@ class LayerGroup(models.Model): | |||
| ) | |||
| order = models.IntegerField(default=0) | |||
| exclusive = models.BooleanField(default=False) | |||
| byVariable = models.BooleanField(default=False) | |||
There was a problem hiding this comment.
Suggested change
| byVariable = models.BooleanField(default=False) | |
| by_variable = models.BooleanField(default=False) |
respect the default python lower_case
submarcos
force-pushed
the
group_byvariables
branch
from
fdbf4f6 to
1097b7d
Compare
submarcos
force-pushed
the
group_byvariables
branch
from
1097b7d to
ab20db4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
==========================================
- Coverage 95.06% 95.04% -0.03%
==========================================
Files 80 80
Lines 2899 2906 +7
==========================================
+ Hits 2756 2762 +6
- Misses 143 144 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so I'm not sure at ALL about some of the stuff here, especially around the migrations. I just applied
make migrationandmigrate