Skip to content

Better serverinfo command #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better serverinfo command #11

wants to merge 2 commits into from

Conversation

RoeeLupo
Copy link

No description provided.

@ersu98
Copy link

ersu98 commented Aug 30, 2018

Remember that "IconURL" shouldnt be used as a function, this gives back an error.

You need to change these two code lines:

.setAuthor(message.guild.name, message.guild.iconURL())
.setThumbnail(message.guild.iconURL())

Change it into this or it simply wont work since iconURL isnt a valid function.

.setAuthor(message.guild.name, message.guild.iconURL)
.setThumbnail(message.guild.iconURL)

@RoeeLupo
Copy link
Author

Sorry, this code was originally made for Discord.js version 12.0.0-dev, in this version it needs to be iconURL() and avatarURL()

@RoeeLupo
Copy link
Author

I've fixed it

ipadpuppydogdude1
ipadpuppydogdude1 approved these changes Dec 4, 2018
View reviewed changes
Copy link

@ipadpuppydogdude1 ipadpuppydogdude1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

Jaylxnn
Jaylxnn approved these changes Jul 31, 2019
View reviewed changes
Copy link

@Jaylxnn Jaylxnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job of improving

ClankoreTheGreat
ClankoreTheGreat reviewed Jun 18, 2020
View reviewed changes
improved-commands/serverinfo.js
Comment on lines +1 to +11
const Discord = require("discord.js");

module.exports.run = async (bot, message, args) => {
function checkDays(date) {
let now = new Date();
let diff = now.getTime() - date.getTime();
let days = Math.floor(diff / 86400000);
return days + (days == 1 ? " day" : " days") + " ago";
};
let verifLevels = ["None", "Low", "Medium", "(╯°□°）╯︵ ┻━┻", "┻━┻ミヽ(ಠ益ಠ)ノ彡┻━┻"];
let region = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cood

DiscordBotJs-zz
DiscordBotJs-zz reviewed Jul 1, 2020
View reviewed changes
improved-commands/serverinfo.js
"russia": ":flag_ru: Russia",
"southafrica": ":flag_za: South Africa"
};
const embed = new Discord.RichEmbed()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const embed = new Discord.MessageEmbed() // Discord V12

RealTitanGod
RealTitanGod reviewed Oct 17, 2020
View reviewed changes
improved-commands/serverinfo.js
.addField("ID", message.guild.id, true)
.addField("Owner", `${message.guild.owner.user.username}#${message.guild.owner.user.discriminator}`, true)
.addField("Region", region[message.guild.region], true)
.addField("Total | Humans | Bots", `${message.guild.members.size} | ${message.guild.members.filter(member => !member.user.bot).size} | ${message.guild.members.filter(member => member.user.bot).size}`, true)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.addField("Total | Humans | Bots", `${message.guild.members.size} | ${message.guild.members.filter(member => !member.user.bot).size} | ${message.guild.members.filter(member => member.user.bot).size}`, true)
.addField("Total | Humans | Bots", `${message.guild.members.cache.size} | ${message.guild.members.cache.filter(member => !member.user.bot).size} | ${message.guild.members.cache.filter(member => member.user.bot).size}`, true)

For Discord.js V12

improved-commands/serverinfo.js
.addField("Owner", `${message.guild.owner.user.username}#${message.guild.owner.user.discriminator}`, true)
.addField("Region", region[message.guild.region], true)
.addField("Total | Humans | Bots", `${message.guild.members.size} | ${message.guild.members.filter(member => !member.user.bot).size} | ${message.guild.members.filter(member => member.user.bot).size}`, true)
.addField("Verification Level", verifLevels[message.guild.verificationLevel], true)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.addField("Verification Level", verifLevels[message.guild.verificationLevel], true)
.addField("Verification Level", message.guild.verificationLevel, true)

For Discord.js V12

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

گوزززز

improved-commands/serverinfo.js
.addField("Region", region[message.guild.region], true)
.addField("Total | Humans | Bots", `${message.guild.members.size} | ${message.guild.members.filter(member => !member.user.bot).size} | ${message.guild.members.filter(member => member.user.bot).size}`, true)
.addField("Verification Level", verifLevels[message.guild.verificationLevel], true)
.addField("Channels", message.guild.channels.size, true)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.addField("Channels", message.guild.channels.size, true)
.addField("Channels", message.guild.channels.cache.size, true)

For Discord.js V12

improved-commands/serverinfo.js
.addField("Total | Humans | Bots", `${message.guild.members.size} | ${message.guild.members.filter(member => !member.user.bot).size} | ${message.guild.members.filter(member => member.user.bot).size}`, true)
.addField("Verification Level", verifLevels[message.guild.verificationLevel], true)
.addField("Channels", message.guild.channels.size, true)
.addField("Roles", message.guild.roles.size, true)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.addField("Roles", message.guild.roles.size, true)
.addField("Roles", message.guild.roles.cache.size, true)

For Discord.js V12

improved-commands/serverinfo.js
.addField("Channels", message.guild.channels.size, true)
.addField("Roles", message.guild.roles.size, true)
.addField("Creation Date", `${message.channel.guild.createdAt.toUTCString().substr(0, 16)} (${checkDays(message.channel.guild.createdAt)})`, true)
.setThumbnail(message.guild.iconURL)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.setThumbnail(message.guild.iconURL)
.setThumbnail(message.guild.iconURL())

For Discord.js V12

Kyro3400
Kyro3400 approved these changes Dec 8, 2020
View reviewed changes
Copy link

@Kyro3400 Kyro3400 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not be staff, but it looks good

ItsEditsss
ItsEditsss reviewed Jan 7, 2021
View reviewed changes
improved-commands/serverinfo.js
.addField("Name", message.guild.name, true)
.addField("ID", message.guild.id, true)
.addField("Owner", `${message.guild.owner.user.username}#${message.guild.owner.user.discriminator}`, true)
.addField("Region", region[message.guild.region], true)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.addField('Server region', message.guild.region, true)

Repository owner deleted a comment from timmy0909 Apr 9, 2021
Repository owner deleted a comment from ClankoreTheGreat Apr 9, 2021
azawat7
azawat7 reviewed May 12, 2021
View reviewed changes
Copy link

@azawat7 azawat7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Korsinemi
Korsinemi reviewed May 27, 2021
View reviewed changes
improved-commands/serverinfo.js
let days = Math.floor(diff / 86400000);
return days + (days == 1 ? " day" : " days") + " ago";
};
let verifLevels = ["None", "Low", "Medium", "(╯°□°）╯︵ ┻━┻", "┻━┻ミヽ(ಠ益ಠ)ノ彡┻━┻"];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azawat7 azawat7 azawat7 left review comments

@RealTitanGod RealTitanGod RealTitanGod left review comments

@kavascriptos kavascriptos kavascriptos left review comments

@Korsinemi Korsinemi Korsinemi left review comments

@DiscordBotJs-zz DiscordBotJs-zz DiscordBotJs-zz left review comments

@ClankoreTheGreat ClankoreTheGreat ClankoreTheGreat left review comments

@ItsEditsss ItsEditsss ItsEditsss left review comments

@Jaylxnn Jaylxnn Jaylxnn approved these changes

@Kyro3400 Kyro3400 Kyro3400 approved these changes

@WebNXP WebNXP WebNXP approved these changes

@ipadpuppydogdude1 ipadpuppydogdude1 ipadpuppydogdude1 approved these changes

@whlack whlack whlack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.