Skip to content

Conversation

kanishka-raisania
Copy link

Description of Change

Added pull-requests: write permission to the approved-label.yml workflow.
This fixes issue #2719 where the Approved Label CI could not add the "approved" label to PRs due to insufficient permissions (403 error).

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
This PR fixes #2719 by updating the workflow permissions.

@realstealthninja
Copy link
Collaborator

if i recall correctly, This fix was tried in a previous pr and didn't work, I am writing an action to fix this, But im happy to test this for now, If you would like you could also help me replace the current workflow, Apparently the github repository for the workflow also has been deleted.

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope tests not passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Approved label CI does not add approved label to pull requests.
3 participants