Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionaries #5351

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Dictionaries #5351

wants to merge 11 commits into from

Conversation

Coding4Hours
Copy link

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work, and ChatGPT's -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java
  • All new code is formatted(added by me)

@alxkm
Copy link
Contributor

alxkm commented Aug 24, 2024

Before beginning the code review of the pull request, the build must pass. Currently, there are issues with the following jobs:

https://github.com/TheAlgorithms/Java/actions/runs/10533336409/job/29189150754?pr=5351
https://github.com/TheAlgorithms/Java/actions/runs/10533336397/job/29189150736?pr=5351
https://github.com/TheAlgorithms/Java/actions/runs/10533336399/job/29189150746?pr=5351

Additionally, it would be beneficial to include tests for this code. Without tests, it's challenging to validate whether the implementation functions as expected.

@Coding4Hours
Copy link
Author

okey dokee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants