Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized LongestPalindromicSubstring.java (Reduced Time Complexity ) #5379

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Narasimha-png
Copy link

@Narasimha-png Narasimha-png commented Aug 24, 2024

Optimized Longest Polindromic Substring from avg run time of 532ms to 13ms

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Optimized Longest Polindromic Substring from avg run time of 532ms to 13ms
@Narasimha-png
Copy link
Author

Reduced Time Complexity from avg run time 434ms to 13 ms

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 46.92%. Comparing base (b231a72) to head (34e7667).

Files Patch % Lines
...lgorithms/strings/LongestPalindromicSubstring.java 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5379      +/-   ##
============================================
+ Coverage     46.90%   46.92%   +0.02%     
- Complexity     2903     2904       +1     
============================================
  Files           525      525              
  Lines         15363    15362       -1     
  Branches       2908     2905       -3     
============================================
+ Hits           7206     7209       +3     
+ Misses         7855     7853       -2     
+ Partials        302      300       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this pull request significantly improve the efficiency and readability of the code. Great work!
One suggestion for further improvement: consider renaming the method f to something more descriptive, like expandAroundCenter

for (int i = 0; i < n / 2; ++i) {
if (s.charAt(lo + i) != s.charAt(hi - i)) {
return false;
public void f(String s, int l, int r) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void f(String s, int l, int r) {
private void expandAroundCenter(String s, int l, int r) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants