-
Notifications
You must be signed in to change notification settings - Fork 19k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized LongestPalindromicSubstring.java (Reduced Time Complexity ) #5379
base: master
Are you sure you want to change the base?
Conversation
Optimized Longest Polindromic Substring from avg run time of 532ms to 13ms
Reduced Time Complexity from avg run time 434ms to 13 ms |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5379 +/- ##
============================================
+ Coverage 46.90% 46.92% +0.02%
- Complexity 2903 2904 +1
============================================
Files 525 525
Lines 15363 15362 -1
Branches 2908 2905 -3
============================================
+ Hits 7206 7209 +3
+ Misses 7855 7853 -2
+ Partials 302 300 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this pull request significantly improve the efficiency and readability of the code. Great work!
One suggestion for further improvement: consider renaming the method f t
o something more descriptive, like expandAroundCenter
for (int i = 0; i < n / 2; ++i) { | ||
if (s.charAt(lo + i) != s.charAt(hi - i)) { | ||
return false; | ||
public void f(String s, int l, int r) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public void f(String s, int l, int r) { | |
private void expandAroundCenter(String s, int l, int r) { |
Optimized Longest Polindromic Substring from avg run time of 532ms to 13ms
clang-format -i --style=file path/to/your/file.java