Skip to content

Added mirror toggle to webcam preview #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmolmalhotra97 wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Added mirror toggle to webcam preview #1049

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd9757a
Add mirror toggle to webcam preview
anmolmalhotra97 Feb 21, 2026
9efbe5a
Remove hover help from webcam flip button
anmolmalhotra97 Feb 21, 2026
327e1ab
Merge branch 'dev' into feature/mirror-toggle-for-webcam-preview
anmolmalhotra97 Feb 24, 2026
f7c8bdf
Add webcam settings and toggle functionality in SettingsView and Webc…
anmolmalhotra97 Feb 24, 2026
9b54e7c
Add flip webcam toggle & rename mirror key
anmolmalhotra97 Feb 24, 2026
9b8b9f4
Merge branch 'dev' into feature/mirror-toggle-for-webcam-preview
anmolmalhotra97 Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion boringNotch/components/Webcam/WebcamView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,15 @@ struct CameraPreviewView: View {

// Track if authorization request is in progress to avoid multiple requests
@State private var isRequestingAuthorization: Bool = false
// Track the current state of mirror effect and the mirror icon in camera preview
@State private var isMirrored: Bool = true
Copy link
Member

@Alexander5015 Alexander5015 Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be stored in Defaults to make it persistent

Copy link
Author

@anmolmalhotra97 anmolmalhotra97 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the code to cater to this suggestion.


var body: some View {
GeometryReader { geometry in
ZStack {
if let previewLayer = webcamManager.previewLayer {
CameraPreviewLayerView(previewLayer: previewLayer)
.scaleEffect(x: -1, y: 1)
.scaleEffect(x: isMirrored ? -1 : 1, y: 1)
.clipShape(RoundedRectangle(cornerRadius: Defaults[.mirrorShape] == .rectangle ? MusicPlayerImageSizes.cornerRadiusInset.opened : 100))
.frame(width: geometry.size.width, height: geometry.size.width)
.opacity(webcamManager.isSessionRunning ? 1 : 0)
Expand All @@ -44,6 +46,22 @@ struct CameraPreviewView: View {
}
}
}
// The mirror toggle button should only be visible if the webcam session is running
Copy link
Member

@Alexander5015 Alexander5015 Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make this a setting in Settings, unless you believe there’s a strong case for keeping it here.

Copy link
Author

@anmolmalhotra97 anmolmalhotra97 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Alexander5015 ,

Would something like this work?

Image

.overlay(alignment: .bottomTrailing) {
if webcamManager.isSessionRunning {
Button {
isMirrored.toggle()
} label: {
Image(systemName: isMirrored ? "arrow.left.and.right.circle.fill" : "arrow.left.and.right.circle")
.font(.system(size: 14, weight: .semibold))
.foregroundStyle(.white.opacity(0.9))
.padding(6)
.background(.black.opacity(0.35), in: Circle())
}
.buttonStyle(.borderless)
.padding(8)
}
}
.onTapGesture {
handleCameraTap()
}
Expand Down