feat: add lyrics column layout with scroll browsing and calendar inli…#1050
Open
rajuptvs wants to merge 2 commits intoTheBoredTeam:mainfrom
Open
feat: add lyrics column layout with scroll browsing and calendar inli…#1050rajuptvs wants to merge 2 commits intoTheBoredTeam:mainfrom
rajuptvs wants to merge 2 commits intoTheBoredTeam:mainfrom
Conversation
Member
|
Looks good overall. Instead of enabling lyrics by default on closed notch, could you add a top toggle button (similar to the calendar one) to show/hide lyrics, and reuse the calendar icon for this? |
…ne panel - Add 3-line synced lyrics column (prev/current/next) beside compact music player when LRC lyrics are available; toggled via Settings or tapping the inline lyric line - Lyrics scroll browsing: mouse scroll gesture moves through lines with a 2-second auto-snap back; uses NSEvent local monitor to reliably capture scroll events behind SwiftUI content layers - Calendar moves into the right panel (replacing lyrics column) toggled from a new capsule button in BoringHeader; separator line collapses the panel - Lyrics disk cache at ~/Library/Application Support/boringNotch/lyrics_cache.json to avoid redundant LRCLIB fetches; auto-retry once on network failure - Retry button shown in lyrics column when lyrics are genuinely unavailable - Add lyricsColumnLayout key to Constants and sub-toggle in Settings
7e1433d to
3c86bbc
Compare
Author
I should be able to add that but don't know if that would be a really good ux decision. Adding an extra click, might prevent users in general to not use the feature entirely (on the flip side can reduce unneccesary calls to fetch lyrics) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notch.update.mov