add Weather tab with minimal, scoped integration#1086
Open
MaydayV wants to merge 3 commits intoTheBoredTeam:devfrom
Open
add Weather tab with minimal, scoped integration#1086MaydayV wants to merge 3 commits intoTheBoredTeam:devfrom
MaydayV wants to merge 3 commits intoTheBoredTeam:devfrom
Conversation
Alexander5015
requested changes
Mar 7, 2026
Member
Alexander5015
left a comment
Alexander5015
left a comment
There was a problem hiding this comment.
The changes seem very disorganized. In order for me to be able to review this properly please esure that:
- All changes for localization keys are in a separate PR. They are not related, and so they shouldn't be in the same PR.
- Code is correctly organized. Right now it seems like the code is isn't in the correct files. Ensure you organize all code into files in a clean way, where all files have proper separation of concerns.
MaydayV
force-pushed
the
dev
branch
2 times, most recently
from
64b76d3 to
26ec366
Compare
- 保留天气功能最小必要改动，移除与功能无关的链式顺序噪音改动。 - 删除 WeatherTabView 中未使用的 hourly UI 路径。 - 删除 WeatherManager 中未使用的小时预报/日出日落数据链路与冗余模型字段。 - 移除 ImageService.swift 中无用导入，并收敛 Tab 标签文本为最小实现。
- remove unused timeZone field from WeatherSnapshot\n- remove unused time fields from current weather decoding models\n- keep weather behavior unchanged while reducing dead code
MaydayV
changed the title
Author
|
@Alexander5015 Please check my changes to the features and code content again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
feat(weather): add Weather tab with minimal, scoped integration
Summary
This PR adds a Weather feature to the notch UI with the smallest practical integration scope.
It includes:
Weathertab in the notch UI.WeatherManagerto fetch and manage weather/geocoding data.It does not include localization key changes or unrelated refactors.
Changes
boringNotch/managers/WeatherManager.swiftboringNotch/components/Notch/WeatherTabView.swiftboringNotch/components/Settings/Views/WeatherSettingsView.swiftboringNotch/models/Constants.swiftboringNotch/enums/generic.swiftboringNotch/components/Tabs/TabSelectionView.swiftboringNotch/components/Notch/BoringHeader.swiftboringNotch/ContentView.swiftboringNotch/components/Settings/SettingsView.swiftboringNotch.xcodeproj/project.pbxprojCleanup Included
WeatherManagerto avoid no-op code.Validation
xcodebuild -project boringNotch.xcodeproj -scheme boringNotch -configuration Debug -destination 'platform=macOS' buildNotes