Feature/bible verse of the day#1097
Open
ShehanCes wants to merge 4 commits into
Open
Conversation
…unds to keep things linear
…d restore OpenNotchOSD file references in project settings
…hing Bible verse fails, allowing UI to display "No verse available".
…ontentView and project settings, simplifying the UI logic for closed notch states.
Author
|
I hope I bring a difference to many lives using boring.notch, I decided to create this feature because this deemed very useful to me. Cheers! |
Contributor
|
I vote for this to not be a native feature but rather one that can be implemented as an extension when extensions support is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional “verse of the day” that can replace the calendar in the home view. Users enable it in Settings → Appearance → Show Bible verse of the day. When enabled, a book icon in the notch header toggles between the calendar and the verse panel.
Changes
New Feature: Bible Verse of the Day
I’ve introduced a "Verse of the Day" panel to the home screen. It’s designed to be "invisible" until needed—it only fetches data when the panel is actually visible to the user. This feature uses bible-api.com to show the verse of the day.
To keep things efficient, the app caches verses by date and uses request deduplication. If the feature is toggled off, no network calls are made at all.
Users can now toggle between their calendar and the daily verse via a pill in the header. If a fetch fails or is still in progress, the panel handles it gracefully with "Loading" or "No verse available" states.
A new toggle, "Show Bible verse of the day," has been added to the Appearance settings.
The Bible verse toggle in the notch header uses the same pill style as the Home and Shelf tab buttons and the other header icons (mirror, settings): capsule background with secondarySystemFill when active and clear when inactive, with a white icon, so it fits the existing notch UI.
Build Fix: Resolving the "Phantom" File
Fixed a frustrating build error caused by a messy rebase.
What happened: A duplicate reference to OpenNotchOSD.swift appeared in the project file, leading Xcode to look for it in the wrong folder.
The fix: I’ve cleaned up the project.pbxproj file, removing the ghost reference and ensuring the file is only tracked in its correct location (OSD/Views). No actual source code was changed here—just some project-file housekeeping to get the app building again.