Open
Conversation
4 tasks
Member
|
Please set the base branch to dev in the future. I already updated the base branch for this PR, but could you rebase your commits on to dev to keep the history clean? |
Ensure VStack content aligns to top instead of being centered vertically. When only calendar is shown, the content was being vertically centered within the 190px notch height, creating a visible gap between the top of the screen and the notch UI. Added explicit top alignment to the content container.
LacombeLouis
force-pushed
the
feat/music_player_ui_hidden
branch
from
95f8db0 to
131efe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a smarter approach to detecting whether a music app is currently active, and updates the UI to show or hide music-related widgets accordingly. It adds a placeholder view when no music app is running, improves transitions, and refines the logic for displaying music and calendar widgets. The changes also include infrastructure for monitoring music app activity and new localizations for the empty music state.
Codebase and State Management Improvements:
MusicManager.destroy().