Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Git cheatsheet #74

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Added Git cheatsheet #74

wants to merge 5 commits into from

Conversation

nhussain22
Copy link

Added Git folder and Git file cheatsheet.
Amended the errors.

@nhussain22 nhussain22 changed the title Git cheatsheet feat: Added Git cheatsheet Jun 14, 2022
Copy link
Contributor

@GooseLF GooseLF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Typing my comments over from the other PR.

You might need to squash your commits now you've got two on this branch :)

guides/cheatsheets/git.md Show resolved Hide resolved
guides/cheatsheets/git.md Show resolved Hide resolved
guides/cheatsheets/git.md Outdated Show resolved Hide resolved
guides/cheatsheets/git.md Show resolved Hide resolved
guides/cheatsheets/git.md Outdated Show resolved Hide resolved
guides/cheatsheets/git.md Outdated Show resolved Hide resolved
guides/cheatsheets/git.md Show resolved Hide resolved
Copy link
Member

@PsypherPunk PsypherPunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

guides/cheatsheets/git.md Outdated Show resolved Hide resolved
guides/cheatsheets/git.md Show resolved Hide resolved
guides/cheatsheets/git.md Outdated Show resolved Hide resolved
guides/cheatsheets/git.md Show resolved Hide resolved
guides/cheatsheets/git.md Show resolved Hide resolved
guides/cheatsheets/git.md Show resolved Hide resolved
@KingMichaelPark
Copy link
Member

I think this may be one for TheKnowledge repo as it is more tutorial/documentation based than high level practices. Personally I would scrap the meme, but I don't feel strongly one way or the other.

Copy link
Contributor

@gvee-uk gvee-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the comment spam!

Most of my musings are about styling, which might seem trivial but we have a way of converting all of this lovely markdown to a static website (i.e. rendered HTML) and if there are bits that deviate, it could make things look odd, especially compared to other pages!


![Git Meme!](assets/images/gitmeme.jpeg)

## **Welcome!**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Titles shouldn't need the additional bold-ificiation here i.e. drop the **'s, please :)
(surprised markdownlint didn't pick up on this, to be honest!

There are exceptions to this rule, but adding what is effectively a <b>bold</b> tag to all headings is unnecessary.


## **Welcome!**

Version control is the essence of engineering here at the Shed. Git is a free
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the Shed" -> "The Shed" 👍

## **Welcome!**

Version control is the essence of engineering here at the Shed. Git is a free
version control system that's responsible for everything GitHub related that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[git is] responsible for everything GitHub related

It's for everything git related. GitHub is just one of many git-based version control system.

and commonly used Git commands for easy reference.

Full Git Techincal Guide can be
[here](https://github.com/TheDataShed/EngineeringHandbook/blob/main/guides/technical-guides/git.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be swapped to a relative link, please? e.g. guides/technical-guides/git.md


## **Cheatsheet includes:**

1. Installation & GUI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list shouldn't be indented - it may confuse the renderer and turn this in to a code block, instead of an ordered list!


Configuring user information used across all local repositories.

_Set a name that is identifiable you when review version history_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to swap these for the next level of headings, rather than an italicised string!


_Set a name that is identifiable you when review version history_.

git config --global user.name “[firstname lastname]”
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst the 4-space indent does work for code blocks, it means we can't benefit from any syntax-highlighting offered by the renderer.

Better to swap these to be code blocks marked by three backticks, and a language hint e.g.

git config --global user.name "[firstname lastname]"


_Set an email address_.

git config --global user.email “[valid-email]”
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap the smart-quotes for vanilla double-quotes, please?

Copy-pasting the command in some terminals with those smart quotes will cause errors.

matches or wildcard globs_.

You can navigate to the
[gitignore](https://www.toptal.com/developers/gitignore/) website where you can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our git policies page suggests the use of https://www.gitignore.io/, so this should probably be consistent!

@@ -0,0 +1,334 @@
# Git Cheatsheet

![Git Meme!](assets/images/gitmeme.jpeg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not averse to the meme, but would be better to change the terminology from master to main as per: https://github.com/github/renaming#renaming-the-default-branch-from-master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants