Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Decouple SQL agent from SSIS #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Decouple SQL agent from SSIS #53

wants to merge 1 commit into from

Conversation

GooseLF
Copy link
Contributor

@GooseLF GooseLF commented Jul 6, 2022

Decoupling deployment of SSIS from the deployment of SQL Agent Jobs/steps/schedules so that the tool can be used solely for the deployment of SQL Agent.

  • deploy.py
    • Introduced new method for deploying SQL Agent
    • Refactored deploy_ssis to account for changes
  • sql-deployment-tools.py
    • Refactored to deploy SSIS and SQL agent separately. SSIS will now only deploy if the ispac argument is set.
  • model.py
    • Made SsisDeployment.project optional
    • Made SsisDeployment.folder optional
  • test/test_model.py
    • Refactored tests to account for changes

@GooseLF GooseLF requested a review from gvee-uk July 6, 2022 14:34
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Unit Test Results

44 tests  ±0   43 ✔️ ±0   0s ⏱️ ±0s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 7e592f0. ± Comparison against base commit 6ff145f.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
test.test_model.TestSsisDeployment ‑ test_SsisDeployment_throws_an_exception_when_folder_is_in_config
test.test_model.TestSsisDeployment ‑ test_SsisDeployment_throws_an_exception_when_folder_is_not_set
test.test_model.TestSsisDeployment ‑ test_SsisDeployment_throws_an_exception_when_project_is_not_in_config
test.test_model.TestSsisDeployment ‑ test_SsisDeployment_throws_an_exception_when_project_name_is_not_set
test.test_model.TestSsisDeployment ‑ test_SsisDeployment_throws_no_exception_when_folder_is_in_config
test.test_model.TestSsisDeployment ‑ test_SsisDeployment_throws_no_exception_when_folder_is_not_set
test.test_model.TestSsisDeployment ‑ test_SsisDeployment_throws_no_exception_when_project_is_not_in_config
test.test_model.TestSsisDeployment ‑ test_SsisDeployment_throws_no_exception_when_project_name_is_not_set

@GooseLF GooseLF requested a review from EuanMason July 6, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant