Loops and Arrays: Flip order of sections on arrays and loops #29705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flows better this way given the contents of the external resources.
github-actions
bot
added
the
Content: Foundations
MaoShizhong
added a commit
to MaoShizhong/theodinproject
that referenced
this pull request
May 16, 2025
To accommodate TheOdinProject/curriculum#29705
Merged
7 tasks
rlmoser99
requested review from
a team and
bycdiaz
and removed request for
a team
KevinMulhern
approved these changes
May 22, 2025
KevinMulhern
pushed a commit
to TheOdinProject/theodinproject
that referenced
this pull request
May 22, 2025
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. --> ## Because To accommodate the changes in TheOdinProject/curriculum#29705 Must be merged alongside that PR to avoid 404s for learners. ## This PR <!-- A bullet point list of one or more items describing the specific changes. --> - Renames the "Arrays and Loops" lesson to "Loops and Arrays", including relevant paths - Fetches renamed lesson in the Foundations path ## Issue <!-- If this PR closes an open issue in this repo, replace the XXXXX below with the issue number, e.g. Closes #2013. If this PR closes an open issue in another TOP repo, replace the #XXXXX with the URL of the issue, e.g. Closes https://github.com/TheOdinProject/curriculum/issues/XXXXX If this PR does not close, but is related to another issue or PR, you can link it as above without the 'Closes' keyword, e.g. 'Related to #2013'. --> N/A ## Additional Information <!-- Any other information about this PR, such as a link to a Discord discussion. --> ## Pull Request Requirements <!-- Replace the whitespace between the square brackets with an 'x', e.g. [x]. After you create the PR, they will become checkboxes that you can click on. --> - [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) - [x] The title of this PR follows the `keyword: brief description of change` format, using one of the following keywords: - `Feature` - adds new or amends existing user-facing behavior - `Chore` - changes that have no user-facing value, refactors, dependency bumps, etc - `Fix` - bug fixes - [x] The `Because` section summarizes the reason for this PR - [x] The `This PR` section has a bullet point list describing the changes in this PR - [x] I have verified all tests and linters pass after making these changes. - [x] If this PR addresses an open issue, it is linked in the `Issue` section - [x] If applicable, this PR includes new or updated automated tests
MaoShizhong
added a commit
to MaoShizhong/curriculum
that referenced
this pull request
May 22, 2025
Missed removing it in TheOdinProject#29705
7 tasks
KevinMulhern
pushed a commit
that referenced
this pull request
May 22, 2025
Missed removing it in #29705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
As discussed in (#29521 (comment)) and (#29521 (comment)), the current order of
arrays -> loops -> array methodsfeels a little odd, especially given the contents of the external resources linked.It would flow a lot better to go loops first then arrays and array methods, since the arrays contents includes loop concepts, and the loop contents need only know a basic description of an array.
This PR
arrays_and_loops.mdtoloops_and_arrays.mdto reflect the new contents order.Issue
Must only be merged at the same time as (TheOdinProject/theodinproject#5000) (which has now been approved) due to a change in the website lesson fetching link.
A quick grep indicates this lesson is no longer linked anywhere in the curriculum so no further changes are necessary.
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection