remove use of deprecated link attribute syntax
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
We recently redid how the link attribute is parsed in the rust compiler. When we did so, we realized we were too permissive, and even when using the wrong syntax would allow so without any warning. We decided to fix this, which would break a few (2 to be precise) crates that accidentally used the wrong syntax. You're one of the lucky two! Congrats, hehe.
Specifically for you, the
link = "static"part of the attribute was silently ignored by the compiler. I think what you were trying to write waskind = "static", which is the change this PR makes.We apologize for the small breaking change we caused you.
Relevant compiler PR introducing this change: rust-lang/rust#143193
Issue tracking this regression: rust-lang/rust#147970