Publish questionnaires via PUT #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbmaclean
commented
Oct 19, 2021
|
|
||
| is( | ||
| decode_json(request( |
There was a problem hiding this comment.
This test was failing. I initially assumed it was me and my new environment; but removing decode_json() here fixed it.
hbmaclean
commented
Oct 20, 2021
| @@ -218,6 +218,43 @@ sub save { | |||
| return $self->id; | |||
| } | |||
|
|
|||
| =head2 publish | |||
There was a problem hiding this comment.
Thinking about this more: Depending on the scope and anticipated lifetime of the project, I might rather write a generic "update()" method that takes a hashref of columns and values to be updated. In fact I'd prefer that save() were generic, functioning like a merge statement (insert or update) - so that the "new vs. update" thinking is when the object is instantiated; and then the object's setters can be used; and finally saved... But again, it depends on how many data changes are likely and how long the project will remain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.