Gerherha add errors, problems and solutions#18
Open
gerherha wants to merge 2 commits intoTheRealKillaruna:mainfrom
Open
Gerherha add errors, problems and solutions#18gerherha wants to merge 2 commits intoTheRealKillaruna:mainfrom
gerherha wants to merge 2 commits intoTheRealKillaruna:mainfrom
Conversation
| for p in bridge.data().values(): | ||
| if p.key()=="Störung": | ||
| entities.append(HargassnerErrorSensor(bridge, name)) | ||
| entities.append(HargassnerProblemSensor(bridge, name)) |
Owner
There was a problem hiding this comment.
This will not work, I think: if the "Störung" flag is set, the corresponding error id is passed as "Störungs Nr". However, there are no corresponding messages for problems or solutions (at least I'm not aware of it), so these categories cannot be handled properly. The new sensors you add process the same "Störungs Nr" as the ErrorSensor, so they will give you incorrect problems and solutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added complete list of errors, problems and solutions from Hargassner service handbook.
Added sensors for problems and solutions