Skip to content

fix: ensure clean logging and result paths #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Theodb wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: ensure clean logging and result paths #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions encodeval/eval_tasks/abstract_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import shutil
from dataclasses import dataclass
import subprocess
from typing import Callable, Dict, Literal
Expand Down Expand Up @@ -154,9 +155,10 @@ def __post_init__(self):
self.tr_args.logging_dir = f"{os.environ['EVAL_MODEL_PATH']}/evaluation/logs/{output_subdir}"
self.results_dir = f"{output_dir}/{model_name}/{output_subdir}"

# Clear old logs if logging directory is not empty
if os.path.exists(self.tr_args.logging_dir) and len(os.listdir(self.tr_args.logging_dir)) > 0:
subprocess.run(f"rm {self.tr_args.logging_dir}/*", shell=True, check=True)
# Clear old logs if logging directory already exists
if os.path.exists(self.tr_args.logging_dir):
shutil.rmtree(self.tr_args.logging_dir, ignore_errors=True)
os.makedirs(self.tr_args.logging_dir, exist_ok=True)

def load_model(self):
"""
Expand Down
14 changes: 8 additions & 6 deletions launch_xp_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,18 @@ def create_selective_cleanup_command(model, task_abbrev, dataset_name, lr_value)
"""Create selective cleanup commands for FORCE_OVERWRITE"""
if not FORCE_OVERWRITE:
return "# No cleanup - FORCE_OVERWRITE is disabled"

lr_str = lr_value.replace('.', '_').replace('-', '_').replace('+', 'p')
model_ft = f"{model}_ftlr_{lr_str}"
path = f"./results/main/{model_ft}/{task_abbrev}/{dataset_name}"
model_path = os.path.join(MODEL_PATH, model)
results_path = f"./results/main/{model}/{task_abbrev}/{dataset_name}"
weights_path = f"{model_path}/evaluation/weights/{task_abbrev}/{dataset_name}"
logs_path = f"{model_path}/evaluation/logs/{task_abbrev}/{dataset_name}"

return f"""
# FORCE_OVERWRITE: Cleanup of existing results, logs, and weights
echo "Performing cleanup for {dataset_name} with LR={lr_value}..."

rm -rf "{path}" 2>/dev/null || true
rm -rf "{results_path}" 2>/dev/null || true
rm -rf "{weights_path}" 2>/dev/null || true
rm -rf "{logs_path}" 2>/dev/null || true

echo "Cleanup completed for {dataset_name} (task: {task_abbrev}, lr: {lr_value})"
"""
Expand Down