refactor: change the querySpec class to record #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested changes
Nov 13, 2024
There was a problem hiding this comment.
I think this, despite tests are working fine, won't work in a communication with a real connector: a json-ld cannot not have the @context attribute.
It is ok, to have a record QuerySpec, but we should ensure that, for the management api, it is transformed in a valid json-ld representation.
Unfortunately the tests made with Prism cannot detect that, we should add some e2e tests based on a real connector, as we're doing in the TypeScript client.
I will create an issue about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we will change the QuerySpec class to a record