Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional regions #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kixiron
Copy link
Contributor

@Kixiron Kixiron commented Jun 9, 2021

Allows the making and using of optional regions, regions that either act like Scope::region() or like nothing at all depending on the parameters given to it, allowing for applications to have their cake and eat it too use regions for dataflow debugging when necessary while still being able to disable them to avoid the overhead incurred by them

Closes #392, unblocks differential-datalog/#990

@Kixiron
Copy link
Contributor Author

Kixiron commented Oct 14, 2021

Any updates on conditional regions, I still need this for differential datalog

@frankmcsherry
Copy link
Member

I'm hesitant to merge this as is, as it is fairly invasive around very sensitive code. I'd much prefer to prototype, and either succeed with or better understand, a user-level type that allows one to wrap either a stack of regions, or nothing. If that ends up being substantially more trouble than doing it in core timely itself, we can revisit.

@Kixiron
Copy link
Contributor Author

Kixiron commented Oct 25, 2021

I'm not sure what you mean by a user level type, timely doesn't expose the required things to create custom subregions so I'm not sure how that'd work. Additionally, I don't actually change anything in pre-existing code, the conditional region is just an additive thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow making conditional regions
2 participants