Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add promo type button ids and default dark styling #68

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Feature/add promo type button ids and default dark styling #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f87c66
:art: update to include dark mode styling for ad types https://gitlab…
thinkjrs Jan 19, 2024
8ed17f2
:art: add dark mode styling for heading + subheading https://gitlab.c…
thinkjrs Jan 19, 2024
256782c
:recycle: remove unused setState setter
thinkjrs Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/NoData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@
: `flex h-16 w-16 flex-shrink-0 items-center justify-center rounded-lg bg-indigo-500`;
const Icon = iconMap.get(icon || 'megaphone') || MegaphoneIcon;
return (
<div className="relative -m-2 flex items-center space-x-4 rounded-xl p-2 focus-within:ring-2 focus-within:ring-indigo-500 hover:bg-slate-100 hover:scale-105 transition ease-in-out duration-300">
<div className="relative -m-2 flex items-center space-x-4 rounded-xl p-2 focus-within:ring-2 focus-within:ring-indigo-500 hover:bg-slate-100 hover:scale-105 transition ease-in-out duration-300 dark:hover:bg-slate-700 group">
<div className={iconClassName}>
<Icon className="h-6 w-6 text-white" aria-hidden="true" />
</div>
<div>
<h4 className="text-sm font-medium text-slate-900 cursor-pointer">
<h4 className="text-sm font-medium text-slate-900 cursor-pointer dark:text-slate-200 dark:group-hover:text-slate-100">
<button
onClick={(event) =>
handleCampaignTypeButtonClick !== undefined
Expand All @@ -102,7 +102,7 @@
<Arrow />
</button>
</h4>
<p className="mt-1 text-sm text-slate-600 cursor-pointer">
<p className="mt-1 text-sm text-slate-600 cursor-pointer dark:text-slate-400 dark:group-hover:text-slate-200">
{description}
</p>
</div>
Expand All @@ -126,12 +126,12 @@
}) {
return (
<>
<h3 className="leading-5 text-base font-bold text-slate-900">
<h3 className="leading-5 text-base font-bold text-slate-900 dark:text-slate-100">
Create a campaign
</h3>
<p className="pb-6">{`Press a campaign type to start the easiest ad campaign you've ever run.`}</p>
<p className="pb-6 dark:text-slate-300">{`Press a campaign type to start the easiest ad campaign you've ever run.`}</p>
<div className="border-t border-gray-200 pb-6 pt-6">
<ul

Check warning on line 134 in src/components/NoData.tsx

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 18.x and ubuntu-latest 

The element ul has an implicit role of list. Defining this explicitly is redundant and should be avoided

Check warning on line 134 in src/components/NoData.tsx

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 18.x and windows-latest 

The element ul has an implicit role of list. Defining this explicitly is redundant and should be avoided

Check warning on line 134 in src/components/NoData.tsx

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 18.x and macOS-latest 

The element ul has an implicit role of list. Defining this explicitly is redundant and should be avoided

Check warning on line 134 in src/components/NoData.tsx

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 20.x and ubuntu-latest 

The element ul has an implicit role of list. Defining this explicitly is redundant and should be avoided

Check warning on line 134 in src/components/NoData.tsx

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 20.x and windows-latest 

The element ul has an implicit role of list. Defining this explicitly is redundant and should be avoided

Check warning on line 134 in src/components/NoData.tsx

View workflow job for this annotation

GitHub Actions / Build, lint, and test on Node 20.x and macOS-latest 

The element ul has an implicit role of list. Defining this explicitly is redundant and should be avoided
role="list"
className="mt-2 grid grid-cols-1 gap-8 pb-6 sm:grid-cols-2"
>
Expand Down
2 changes: 1 addition & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function PromoDashboard({
const [statsHighlightTimeseries, setStatsHighlightTimeseries] = useState<
CampaignStatsData | undefined
>(undefined);
const [defaultCampaignTypeContent, setDefaultCampaignTypeContent] = useState<
const [defaultCampaignTypeContent] = useState<
{ name: string; description?: string; icon?: string; color?: string }[]
>([...options.campaignTypes, ...(dashboardOptions?.campaignTypes || [])]);
const [clickedStatsClassName, setClickedStatsClassName] = useState<string>(
Expand Down
Loading