Fix native module compilation for macOS (Electron 38) and Windows (Spectre mitigation) #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves native-keymap build failures on macOS caused by missing C++20 compiler flags. The native-keymap dependency requires C++20 features (constexpr, concept, requires) for Electron 38 compatibility, but the macOS build configuration was missing the necessary xcode_settings. Changes: - Added patch-package to apply C++20 fix to native-keymap binding.gyp - Created patches/native-keymap+3.3.5.patch with xcode_settings for macOS - Enabled npmRebuild in electron-builder.yml to properly rebuild native modules for both x64 and arm64 architectures - Added postinstall script to automatically apply patches The patch adds CLANG_CXX_LANGUAGE_STANDARD: 'c++20' to the macOS build configuration in native-keymap, allowing it to compile successfully against Electron 38 headers. Tested on: - macOS Ventura 13.7 (Intel iMac 2017) - x64 build - macOS Sequoia 15.x (M4 MacBook Air 2025) - arm64 build Fixes Tkaixiang#8
The postinstall script requires patch-package to be installed as a devDependency. Without it, npm install fails with 'patch-package: command not found'. This commit completes the native module compilation fix by ensuring patch-package is available to apply the native-keymap patches during installation.
Extends the existing native-keymap patch to disable Spectre mitigation requirements on Windows. This allows the native module to compile without requiring Spectre-mitigated libraries from Visual Studio. Changes: - Set 'SpectreMitigation': 'false' in binding.gyp msvs_configuration_attributes - Retains existing macOS C++20 fix This is a test commit to verify the fix works on Windows before merging into the main PR branch.
- Updated package-lock.json for Node.js 20.19.5 compatibility - Added test results showing successful Windows build - Confirmed Spectre mitigation bypass patch works correctly - Windows installer created: marktext-win-x64-0.18.5-setup.exe (123.5 MB) All native modules (native-keymap, ced, keytar) compiled successfully without MSB8040 Spectre errors.
mikejoseph23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes native module compilation issues on both macOS and Windows by patching
native-keymapbindingconfiguration.
Issues Fixed
macOS (Electron 38)
error: 'value' is unavailable: introduced in macOS 11.0Windows
MSB8040: Spectre-mitigated libraries are required for this projectChanges
Added Dependencies
patch-packageas devDependency to apply native module patches during installationPatch File
Created
patches/native-keymap+3.3.5.patchwith:'SpectreMitigation': 'false'(Windows fix)'CLANG_CXX_LANGUAGE_STANDARD': 'c++20'
'CLANG_CXX_LIBRARY': 'libc++'
'MACOSX_DEPLOYMENT_TARGET': '11.0'
Package.json
"postinstall": "patch-package"script to automatically apply patches after npm installBuild Requirements
Installation Instructions
Standard Installation (Recommended)
Fixes Issue #8