Fix subdirectories not displaying recursively in file explorer sidebar #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a critical bug where subdirectories were not appearing in the file explorer sidebar when expanding folders, while files displayed correctly. Changes: - Add missing self-import to treeFolder.vue for recursive rendering (Vue 3 script setup requires explicit imports including self-references) - Use local reactive state for isCollapsed to properly track folder expansion state - Change v-if to v-show for folder-contents to maintain DOM presence - Use proper v-for keys based on item IDs instead of array indexes - Implement alphabetical sorting for folders in addDirectory - Add event buffering for directory changes before tree initialization - Extract _processTreeEvent method for cleaner event handling Root cause: The recursive Folder component was referenced in the template as <folder> but was never imported in the script setup section, causing Vue to fail silently when trying to render nested folder components. Testing: Verified that subdirectories now render correctly when expanding folders in the sidebar, while maintaining proper file display and folder state persistence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Problem
Subdirectories are not displaying recursively in the file explorer sidebar. Only the first level of folders is expandable, but any sub-folders underneath are not listed even though they exist in the filesystem.
Root Cause
The folder tree rendering logic in
treeFolder.vuewasn't properly handling nested folder structures. The recursive folder component wasn't being invoked for child folders.Solution
Fixed the recursive folder rendering:
treeFolder.vueto properly render child folders recursivelyAdditional Changes
<ul>elements in rendered markdown for better readabilityTesting
Tested on macOS with deeply nested folder structures. All subdirectories now display correctly and can be expanded/collapsed as expected.
Files Changed
src/renderer/src/components/sideBar/treeFolder.vue- Fixed recursive folder renderingsrc/renderer/src/components/sideBar/tree.vue- Updated folder tree structuresrc/renderer/src/store/project.js- Fixed directory handling logicsrc/renderer/src/store/treeCtrl.js- Improved tree controlsrc/muya/themes/default.css- Added ul paddingstatic/themes/default.css- Added ul padding