feat: add batch_concurrency to ModelDefaultsConfig
#5481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etonlels
force-pushed
the
batch-concurrency-model-defaults
branch
2 times, most recently
from
2efd868 to
6aff870
Compare
etonlels
changed the title
This change allows users to set a default `batch_concurrency` value in their project configuration that will be applied to incremental models. - Added `batch_concurrency` field to `ModelDefaultsConfig` - Updated `create_model_kind()` to apply `batch_concurrency` default to models inheriting from `_IncrementalBy` when not explicitly set - Skips applying default for subclasses with hardcoded `batch_concurrency` (e.g., `IncrementalByUniqueKeyKind` which has `batch_concurrency: Literal[1]`) - Added comprehensive tests covering default behavior and edge cases 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
etonlels
force-pushed
the
batch-concurrency-model-defaults
branch
from
6aff870 to
fff244a
Compare
etonlels
changed the title
batch_concurrency to ModelDefaultsConfig
eakmanrq
approved these changes
Oct 3, 2025
|
Does it make sense to add |
My team just cares about |
|
It's just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to set a default
batch_concurrencyvalue in theirproject configuration that will be applied to incremental models.
batch_concurrencyfield toModelDefaultsConfigcreate_model_kind()to applybatch_concurrencydefault to modelsinheriting from
_IncrementalBywhen not explicitly setbatch_concurrency(e.g.,
IncrementalByUniqueKeyKindwhich hasbatch_concurrency: Literal[1])🤖 Generated with Claude Code