ci: fix benchmark running #5570
Conversation
benfdking
force-pushed
the
fix_benchmark
branch
from
0f864fe to
2297255
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables the benchmark CI step in CircleCI and configures it to run single-threaded. The benchmark was previously commented out and is now being re-enabled with optimizations for CI environments.
- Re-enabled the
benchmark-cistep in CircleCI configuration (skipping Python 3.9) - Added
--processes=1flag to the benchmark command to force single-process execution
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Added --processes=1 flag to benchmark-ci target to run benchmarks in single-process mode |
| .circleci/continue_config.yml | Uncommented and restructured the benchmark-ci step to run on all Python versions except 3.9 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Makefile
Outdated
|
|
||
| benchmark-ci: | ||
| python benchmarks/lsp_render_model_bench.py --debug-single-value | ||
| python benchmarks/lsp_render_model_bench.py --debug-single-value --processes=1 |
There was a problem hiding this comment.
The --processes=1 flag is not recognized by the pyperf.Runner() in the benchmark script. The script uses pyperf.Runner() without any argument parsing, so this flag will cause the script to fail. If you need to control the number of processes, you should initialize the Runner with pyperf.Runner(processes=1) in the script itself, or use pyperf's built-in flag --processes 1 (note the space instead of equals sign) which is automatically handled by pyperf.Runner().
| python benchmarks/lsp_render_model_bench.py --debug-single-value --processes=1 | |
| python benchmarks/lsp_render_model_bench.py --debug-single-value --processes 1 |
- by skipping in 3.9 for time being - newer google libraries print warnings which break the lsp stream
benfdking
force-pushed
the
fix_benchmark
branch
from
2297255 to
f9a0cc8
Compare
Reenables benchmark but not in 3.9 because of issue related to python/cpython#32073 which was not backported to 3.9 which causes the deadlock