Skip to content

Update the npm dependency resolution to traverse the dependency graph rather than the node_modules dir #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update the npm dependency resolution to traverse the dependency graph rather than the node_modules dir #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions ...ages/generate-license-file/src/lib/internal/resolveDependencies/resolveNpmDependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,14 @@ export const resolveDependenciesForNpmProject = async (
const arborist = new Arborist({ path });
const topNode = await arborist.loadActual();

const visitedNodes = new Set<Node | Link>();

const parseNode = async (node: Node | Link) => {
if (visitedNodes.has(node)) {
return;
}
visitedNodes.add(node);

if (node.dev || node.peer) {
return;
}
Expand Down Expand Up @@ -73,13 +80,19 @@ export const resolveDependenciesForNpmProject = async (
logger.warn(warningLines.join("\n"));
}

for (const child of node.children.values()) {
await parseNode(child);
for (const edgeOut of node.edgesOut.values()) {
const edgeNode = edgeOut.to;
if (edgeNode) {
await parseNode(edgeNode);
}
}
};

for (const child of topNode.children.values()) {
await parseNode(child);
const isTopLevel = isTopLevelDependency(child);
if (isTopLevel) {
await parseNode(child);
}
}
};

Expand All @@ -88,3 +101,13 @@ const resolvePath = (path: string): string => {

return dirname(absolutePackageJson);
};

const isTopLevelDependency = (node: Node | Link): boolean => {
for (const edge of node.edgesIn) {
if (edge.from?.isRoot) {
return true;
}
}

return false;
};
Loading