Allow setting custom TCP receive buffer size #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
PhilipRoman
force-pushed
the
receive-buffer-size
branch
2 times, most recently
from
84545ec
to
dd55832
Compare
Also increase default to 64K for performance improvement.
PhilipRoman
force-pushed
the
receive-buffer-size
branch
from
dd55832
to
f625a1a
Compare
|
@PhilipRoman When is the next release planned? I'm interested in this feature as I've had issues with the current bandwith limitations. |
|
@PhilipRoman Same here. We also wait for this release. Any update when release is planned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new setter/getter which controls the TCP receive buffer size (previously hardcoded as 16K)
Motivation and Context
This is intended to solve #1406 in a more general way
Types of changes
Checklist:
TODO
Before merging this I would like to manually verify that setting the buffer size affects performance as expectedTested, changing the buffer size affects throughput as expected